fix rain

core/daynight/environment_manager.gd

@@ -3,7 +3,6 @@ extends Node3D
 
 const NOISE_TEXTURE: Texture2D = preload("res://core/daynight/noise.tres")
 const WEATHER_SHADER: Material = preload("res://core/daynight/weather_overlay.tres")
-const WEATHER_PLAIN_SHADER: Material = preload("res://core/daynight/weather_plain_shader.tres")
 const DYNAMIC_ENVIRONMENT_UPDATES_PER_FRAME: int = 2 #how many update of the environment (apply materials) will be done per frame
 
 @export var environment_config: EnvironmentConfig
@@ -134,7 +133,7 @@ func _apply_dynamic_environment_materials(node: Node) -> void:
 		_apply_weather_overlay_to_node(node, WEATHER_SHADER)
 
 	if node.is_in_group("weather_vegetables_node"):
-		_apply_weather_overlay_to_node(node, WEATHER_PLAIN_SHADER)
+		_clear_weather_overlay_from_node(node)
 
 func ApplyWindNoiseToMaterials():
 	for node in get_tree().get_nodes_in_group("wind_node"):
@@ -160,15 +159,50 @@ func ApplyWeatherShaderToMaterials():
 		_apply_weather_overlay_to_node(node, WEATHER_SHADER)
 
 	for node in get_tree().get_nodes_in_group("weather_vegetables_node"):
-		_apply_weather_overlay_to_node(node, WEATHER_PLAIN_SHADER)
+		_clear_weather_overlay_from_node(node)
 
 func _apply_weather_overlay_to_node(node: Node, material: Material) -> void:
 	if node is GeometryInstance3D:
-		node.material_overlay = material
+		if _geometry_uses_alpha_texture(node):
+			node.material_overlay = null
+		else:
+			node.material_overlay = material
 
 	for child in node.get_children():
 		_apply_weather_overlay_to_node(child, material)
 
+func _clear_weather_overlay_from_node(node: Node) -> void:
+	if node is GeometryInstance3D:
+		node.material_overlay = null
+
+	for child in node.get_children():
+		_clear_weather_overlay_from_node(child)
+
+func _geometry_uses_alpha_texture(node: GeometryInstance3D) -> bool:
+	var material_override := node.material_override as ShaderMaterial
+	if _shader_material_uses_alpha_texture(material_override):
+		return true
+
+	if node is MeshInstance3D:
+		for surface_index in node.get_surface_override_material_count():
+			var surface_material := node.get_surface_override_material(surface_index) as ShaderMaterial
+			if _shader_material_uses_alpha_texture(surface_material):
+				return true
+
+		if node.mesh:
+			for surface_index in node.mesh.get_surface_count():
+				var mesh_material := node.mesh.surface_get_material(surface_index) as ShaderMaterial
+				if _shader_material_uses_alpha_texture(mesh_material):
+					return true
+
+	return false
+
+func _shader_material_uses_alpha_texture(material: ShaderMaterial) -> bool:
+	if material == null or material.shader == null:
+		return false
+
+	return material.shader.code.find("alpha_texture") != -1
+
 func select_day_time(normalized_time: float) -> void:
 	#set show_day_time_debug = true to show debug on screen
 	#normalized_time is a value between 0 and 1; the time of the day is calculate as "normalized_time" * 1440; day_time is the step to pass from sunrise, to day, to sunset, to night